[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 8/8] target/ppc: simplify get_cpu_vsr

From: Richard Henderson
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 8/8] target/ppc: simplify get_cpu_vsrh() and get_cpu_vsrl() functions
Date: Wed, 6 Mar 2019 14:27:47 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 3/6/19 1:48 PM, Mark Cave-Ayland wrote:
> The only part I'm now not sure about is whether from the above you want to 
> keep
> fpr_offset() and vsrh_offset(), or whether in the final patch in the series I 
> can
> introduce vsr64_offset() similar to avr64_offset() and switch the callers 
> over to use it?

I would not keep vsrh_offset and would introduce vsr64_offset.

But I would keep fpr_offset, specifically for fpr stuff.
If you like, you can have it forward to vsr64_offset(r, high=true).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]