Re: [Qemu-ppc] [Qemu-devel] [Qemu-trivial] Whitespace cleanup: target/ppc/translate_init.inc.c

[Philippe Mathieu-Daudé]

On 1/11/19 8:20 AM, Laurent Vivier wrote:
> On 11/01/2019 01:37, David Gibson wrote:
>> On Wed, Jan 09, 2019 at 11:15:26AM +0100, Laurent Vivier wrote:
>>> Hi Jon,
>>>
>>> please cc: qemu-devel and MAINTAINERS when you send a patch.
>>>
>>> You can have the list of maintainers using a script in qemu directory:
>>>
>>>     ./scripts/get_maintainer.pl XXXX.patch
>>>
>>> Thanks,
>>> Laurent
>>
>> Hrm.  Like the other patch, I didn't seem to receive this - I checked
>> back through my archives.  I think something must be not working with
>> email from Jon to me, although I can't quite imagine what.
>>
>>>
>>> On 03/01/2019 20:58, Jon Diekema wrote:
>>>> From: Jon Diekema <address@hidden>
>>>> Date: Tue, 25 Dec 2018 04:03:04 -0500
>>>> Subject: Whitespace cleanup: target/ppc/translate_init.inc.c
>>>>
>>>> Signed-off-by: Jon Diekema <address@hidden>
>>>> ---
>>>>   target/ppc/translate_init.inc.c | 4 ++--
>>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/target/ppc/translate_init.inc.c
>>>> b/target/ppc/translate_init.inc.c
>>>> index c971a5faf7..b5f4c9bd55 100644
>>>> --- a/target/ppc/translate_init.inc.c
>>>> +++ b/target/ppc/translate_init.inc.c
>>>> @@ -5237,7 +5237,7 @@ static void init_proc_601(CPUPPCState *env)
>>>>                    0x00000000);
>>>>       /* Memory management */
>>>>       init_excp_601(env);
>>>> -    /* XXX: beware that dcache line size is 64
>>>> +    /* XXX: beware that dcache line size is 64
>>>>        *      but dcbz uses 32 bytes "sectors"
>>>>        * XXX: this breaks clcs instruction !
>>>>        */
>>>> @@ -10485,7 +10485,7 @@ static void ppc_cpu_class_init(ObjectClass
>>>> *oc, void *data)
>>>>       cc->tcg_initialize = ppc_translate_init;
>>>>   #endif
>>>>       cc->disas_set_info = ppc_disas_set_info;
>>>> -
>>>> +
>>>>       dc->fw_name = "PowerPC,UNKNOWN";
>>>>   }
>>>>  
>>>
>>
> 
> Likewise. Only sent to qemu-trivial ML.

Also tools like patchew are only subscribed to address@hidden, so
this patch is missing there too.

The documentation seems clear enough although:

- README:

  Submitting patches
  ==================

  When submitting patches, one common approach is to use 'git
  format-patch' and/or 'git send-email' to format & send the mail to the
  address@hidden mailing list. [...]

- MAINTAINERS

  All patches CC here
  L: address@hidden