[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v5 23/36] spapr/xive: add migration support for KV

From: Cédric Le Goater
Subject: Re: [Qemu-ppc] [PATCH v5 23/36] spapr/xive: add migration support for KVM
Date: Fri, 30 Nov 2018 08:04:39 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0

[ ... ]

>>>> +/*
>>>> + * The sPAPRXive KVM model migration priority is higher to make sure
>>> Higher than what?
>> Than the XiveTCTX and XiveSource models.
>>>> + * its 'pre_save' method runs before all the other XIVE models. It
>>> If the other XIVE components are children of sPAPRXive (which I think
>>> they are or could be), then I believe the parent object's pre_save
>>> will automatically be called first.
>> ok. XiveTCTX are not children of sPAPRXive but that might not be 
>> a problem anymore with the VMState change handler.
> Ah, right.  You might need the handler in the machine itself then - we
> already have something like that for XICS, IIRC.

exactly. For XIVE, I am using the post_load method at the machine level, 
which should be last. The XIVE sources PQs are restored when the 
machine starts running again in the VM state change handler. So I don't
need the priority at all on the destination. I will try to remove the
prio, I agree it's a bit ugly.  


reply via email to

[Prev in Thread] Current Thread [Next in Thread]