Re: [Qemu-ppc] [Qemu-devel] [PATCH qemu] configure/fdt: Use more strict test for libfdt version

[Daniel P . Berrangé]

On Thu, Nov 15, 2018 at 02:56:59PM +1100, Alexey Kardashevskiy wrote:
> The libfdt installed in the system is preferred to the dtc submodule by
> default. The recent libfdt update added a new symbol - fdt_check_full -
> and this breaks compile if there is an older libfdt installed in
> the system.

Unless I'm missing something, QEMU doesn't use the fdt_check_full symbol,
so why would the lack of this symbol cause a compile failure. 

It should be fine if the dtc submodule contains a newer libfdt than the
host system. As long as QEMU doesn't actually need any of the APIs in
the newer libfdt we should be able to continue using the older system
version if it is present.

Could you elaborate on what build problems you are having.

> This changes the test to force ./configure into using newer libfdt.

I'm not convinced we want todo that.

> 
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 74e313a..7e16a6c 100755
> --- a/configure
> +++ b/configure
> @@ -3826,7 +3826,7 @@ if test "$fdt" != "no" ; then
>    cat > $TMPC << EOF
>  #include <libfdt.h>
>  #include <libfdt_env.h>
> -int main(void) { fdt_first_subnode(0, 0); return 0; }
> +int main(void) { fdt_check_full(NULL, 0); return 0; }
>  EOF
>    if compile_prog "" "$fdt_libs" ; then
>      # system DTC is good - use it

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|