qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH] vga: make stdvga the global default


From: Gerd Hoffmann
Subject: Re: [Qemu-ppc] [PATCH] vga: make stdvga the global default
Date: Thu, 5 Jul 2018 08:30:03 +0200
User-agent: NeoMutt/20180622

> > -    m->default_display = "std";
> >      machine_class_allow_dynamic_sysbus_dev(m, TYPE_RAMFB_DEVICE);
> 
> I wouldn't like to do this.  Long term, it would be a good idea
> to have zero machines with default_display==NULL, so let's keep
> default_machine="std" on PC?

Fine with me, I'll send a v2.

> > -        } else if (vga_interface_available(VGA_CIRRUS)) {
> > -            vga_model = "cirrus";
> >          } else if (vga_interface_available(VGA_STD)) {
> >              vga_model = "std";
> > +        } else if (vga_interface_available(VGA_CIRRUS)) {
> > +            vga_model = "cirrus";
> 
> If we don't make the machines above have default_display=NULL, we
> won't need this hunk, right?  In either case, I suggest doing
> this change on a separate patch.

ok.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]