[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH qemu] spapr_pci: Fix obsolete comment about MSIX e
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH qemu] spapr_pci: Fix obsolete comment about MSIX encoding in addr/data |
Date: |
Tue, 18 Jul 2017 13:33:01 +1000 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Tue, Jul 18, 2017 at 12:00:33PM +1000, Alexey Kardashevskiy wrote:
> f1c2dc7c866a "spapr-pci: rework MSI/MSIX" (07/2013) changed MSIX encoding
> but forgot to change the comment so this changes it.
>
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
Applied to ppc-for-2.10, thanks.
> ---
> hw/ppc/spapr_pci.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
> index a52dcf8ec0..4b895c5a2a 100644
> --- a/hw/ppc/spapr_pci.c
> +++ b/hw/ppc/spapr_pci.c
> @@ -723,9 +723,7 @@ static PCIINTxRoute spapr_route_intx_pin_to_irq(void
> *opaque, int pin)
> /*
> * MSI/MSIX memory region implementation.
> * The handler handles both MSI and MSIX.
> - * For MSI-X, the vector number is encoded as a part of the address,
> - * data is set to 0.
> - * For MSI, the vector number is encoded in least bits in data.
> + * The vector number is encoded in least bits in data.
> */
> static void spapr_msi_write(void *opaque, hwaddr addr,
> uint64_t data, unsigned size)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature