[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 23/31] ppc: use DIV_ROUND_UP
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH 23/31] ppc: use DIV_ROUND_UP |
Date: |
Sun, 2 Jul 2017 13:04:40 +1000 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Thu, Jun 22, 2017 at 02:41:56PM +0200, Marc-André Lureau wrote:
> I used the clang-tidy qemu-round check to generate the fix:
> https://github.com/elmarco/clang-tools-extra
>
> Signed-off-by: Marc-André Lureau <address@hidden>
Acked-by: David Gibson <address@hidden>
> ---
> target/ppc/mem_helper.c | 2 +-
> target/ppc/translate.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c
> index e6383c6bfa..a34e604db3 100644
> --- a/target/ppc/mem_helper.c
> +++ b/target/ppc/mem_helper.c
> @@ -111,7 +111,7 @@ void helper_lswx(CPUPPCState *env, target_ulong addr,
> uint32_t reg,
> uint32_t ra, uint32_t rb)
> {
> if (likely(xer_bc != 0)) {
> - int num_used_regs = (xer_bc + 3) / 4;
> + int num_used_regs = DIV_ROUND_UP(xer_bc, 4);
> if (unlikely((ra != 0 && lsw_reg_in_range(reg, num_used_regs, ra)) ||
> lsw_reg_in_range(reg, num_used_regs, rb))) {
> raise_exception_err_ra(env, POWERPC_EXCP_PROGRAM,
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index c0cd64d927..76f9ccde25 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -2882,7 +2882,7 @@ static void gen_lswi(DisasContext *ctx)
> }
> if (nb == 0)
> nb = 32;
> - nr = (nb + 3) / 4;
> + nr = DIV_ROUND_UP(nb, 4);
> if (unlikely(lsw_reg_in_range(start, nr, ra))) {
> gen_inval_exception(ctx, POWERPC_EXCP_INVAL_LSWX);
> return;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-ppc] [PATCH 23/31] ppc: use DIV_ROUND_UP,
David Gibson <=