Re: [Qemu-ppc] [PATCH] target-ppc: Fix openpic timer read register offset

[alarson]

David Gibson <address@hidden> wrote on 06/04/2017 07:55:34 
PM:

> From: David Gibson <address@hidden>
> To: Aaron Larson <address@hidden>
> Cc: address@hidden, address@hidden, address@hidden
> Date: 06/04/2017 07:55 PM
> Subject: Re: [PATCH] target-ppc: Fix openpic timer read register offset
> 
> On Fri, Jun 02, 2017 at 04:32:59AM -0700, Aaron Larson wrote:
> > 
> > openpic_tmr_read() is incorrectly computing register offset of the
> > TCCR, TBCR, TVPR, and TDR registers when accessing the open pic timer
> > registers.  ...
> 
> Applied to ppc-for-2.10.  It looks saner than the existing code, but I
> don't know openpic well enough to really review it; so I'm trusting
> you on that.

Thanks David, I'll have an updated timer patch out later today for the
timer that actually times.  I'm reasonably sure the resulting code is
correct because we have the same binary working on real hardware and
on QEMU.