[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 7/8] target/ppc: optimize various functions using
|
From: |
Laurent Vivier |
|
Subject: |
Re: [Qemu-ppc] [PATCH 7/8] target/ppc: optimize various functions using extract op |
|
Date: |
Thu, 11 May 2017 10:46:01 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 11/05/2017 02:41, David Gibson wrote:
> On Wed, May 10, 2017 at 05:05:34PM -0300, Philippe Mathieu-Daudé wrote:
>> Applied using Coccinelle script.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
>
> Reviewed-by: David Gibson <address@hidden>
David, look at Nikunj's comments: only the two first changes are correct.
'andi" uses a mask, but extract uses a 'width'. Philippe's changes work
only when mask = 1.
Thanks,
Laurent