[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH qemu v6] memory/iommu: QOM'fy IOMMU MemoryRegion
From: |
Alexey Kardashevskiy |
Subject: |
Re: [Qemu-ppc] [PATCH qemu v6] memory/iommu: QOM'fy IOMMU MemoryRegion |
Date: |
Tue, 9 May 2017 21:34:34 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 09/05/17 19:14, Peter Xu wrote:
>> +void memory_region_init_iommu(IOMMUMemoryRegion *iommu_mr,
>> + Object *owner,
>> + const MemoryRegionIOMMUOps *ops,
>> + const char *name,
>> + uint64_t size)
>> +{
>> + memory_region_init_iommu_type(TYPE_IOMMU_MEMORY_REGION, iommu_mr,
>> + owner, ops, name, size);
>
> I see that memory_region_init_iommu_type() is only used to create
> TYPE_IOMMU_MEMORY_REGION typed MRs. Then would
> memory_region_init_iommu() enough for us? Or do you have plan to add
> new memory region types?
Yes, I am still thinking of adding TYPE_SPAPR_TCE_IOMMU_MEMORY_REGION
later, for strict types checking when enabling in-kernel DMA operations
support (our SPAPR thingy).
--
Alexey