[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v3 1/3] audio: Move arch_init audio code to hw/aud
From: |
Thomas Huth |
Subject: |
Re: [Qemu-ppc] [PATCH v3 1/3] audio: Move arch_init audio code to hw/audio/soundhw.c |
Date: |
Tue, 9 May 2017 07:49:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 08.05.2017 22:57, Eduardo Habkost wrote:
> There's no reason to keep the soundhw table in arch_init.c. Move
> that code to a new hw/audio/soundhw.c file.
>
> While moving the code, trivial coding style issues were fixed.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> Changes v2 -> v3:
> * Update hw/ppc/prep.c to include hw/audio/audio.h too
>
> Changes v1 -> v2:
> * Rebase to latest qemu.git master
> ---
> include/hw/audio/audio.h | 3 +
> include/sysemu/arch_init.h | 2 -
> arch_init.c | 124 -----------------------------------
> hw/audio/soundhw.c | 156
> +++++++++++++++++++++++++++++++++++++++++++++
> hw/ppc/prep.c | 1 +
> vl.c | 1 +
> hw/audio/Makefile.objs | 2 +
> 7 files changed, 163 insertions(+), 126 deletions(-)
> create mode 100644 hw/audio/soundhw.c
Good idea!
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-ppc] [PATCH v3 0/3] arch_init: Move soundhw code to hw/audio/soundhw.c, Eduardo Habkost, 2017/05/08
- [Qemu-ppc] [PATCH v3 2/3] audio: Rename audio_init() to soundhw_init(), Eduardo Habkost, 2017/05/08
- [Qemu-ppc] [PATCH v3 1/3] audio: Move arch_init audio code to hw/audio/soundhw.c, Eduardo Habkost, 2017/05/08
- [Qemu-ppc] [PATCH v3 3/3] audio: Rename hw/audio/audio.h to hw/audio/soundhw.h, Eduardo Habkost, 2017/05/08
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 0/3] arch_init: Move soundhw code to hw/audio/soundhw.c, no-reply, 2017/05/08
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 0/3] arch_init: Move soundhw code to hw/audio/soundhw.c, Eduardo Habkost, 2017/05/16