Re: [Qemu-ppc] [PATCH] ppc: Make uninorth interrupt swizzling identical to Grackle

[Mark Cave-Ayland]

On 21/11/16 23:05, David Gibson wrote:

> On Mon, Nov 21, 2016 at 12:12:31AM +1000, BALATON Zoltan wrote:
>> From: Benjamin Herrenschmidt <address@hidden>
>>
>> It's currently broken as it uses an incorrect shift, it tries
>> to use the slot number but uses the top bits of the bus number
>> instead.
>>
>> Note: Neither implementation matches what OpenBIOS ends up putting
>> in the device-tree either, which will have to be fixed separately.
>>
>> This is not quite correct for modelling a real Mac since Apple
>> tend to tie all 4 interrupt lines of a slot together and have
>> separate interrupts for every slot and every motherboard devices
>> going straight to the PIC but we'll sort that out later.
>>
>> Signed-off-by: Benjamin Herrenschmidt <address@hidden>
>> ---
>>  hw/pci-host/uninorth.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> This needs a corresponding fix in OpenBIOS but this has to be
>> committed first for that. As this is already broken making this change
>> should not make things worse as they are now. Could we get this in now
>> as a bugfix commit?
> 
> Applied to ppc-for-2.8.

Is this going in for 2.8? If so, I'll need to apply the corresponding
patch to OpenBIOS to match and also do a PPC testing cycle to make sure
that there are no regressions on other OSs. Plus it would be useful to
get both pull requests in close proximity as this will break bisection.


ATB,

Mark.