Re: [Qemu-ppc] [Qemu-devel] [PATCH 09/32] ppc: Make float_invalid_op_excp() pass the return address

[Benjamin Herrenschmidt]

On Fri, 2016-07-29 at 07:57 +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2016-07-28 at 21:36 +0530, Richard Henderson wrote:
> > 
> > On 07/27/2016 03:51 AM, Benjamin Herrenschmidt wrote:
> > > 
> > > 
> > > +            /* GETPC() works here because this is inline */
> > > +            raise_exception_err_ra(env, POWERPC_EXCP_PROGRAM,
> > > +                                   POWERPC_EXCP_FP | op,
> > > GETPC());
> > 
> > It doesn't, with --enable-debug, aka -O0.
> 
> Will that prevent even an explicit inline statement ? Would
> __attribute__((always_inline)) help there ?

Ah found this in gcc docs:

<<
GCC does not inline any functions when not optimizing unless you
specify the ‘always_inline’ attribute for the function, like this:

     /* Prototype.  */
     inline void foo (const char) __attribute__((always_inline));
>>

I'll add the attribute.

Cheers,
Ben.