Re: [Qemu-ppc] [Qemu-devel] [PATCH V5 1/5] hw/ppc: realize the PCI root bus as part of mac99 init

[Marcel Apfelbaum]

On 06/28/2016 05:56 AM, David Gibson wrote:
> On Mon, Jun 27, 2016 at 06:38:31PM +0300, Marcel Apfelbaum wrote:
> > Mac99's PCI root bus is not part of a host bridge,
> > realize it manually.
>
> Um.. how did this ever work?

Well, the only thing the PCI bus realize does is
to register the VM migration state, so only migration was affected.

However, patch 2/5 adds to the realize function bus_master initialization code
for all devices attached to the bridge.

Thanks,
Marcel

> > Signed-off-by: Marcel Apfelbaum <address@hidden>
> > ---
> >   hw/ppc/mac_newworld.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
> > index 32e88b3..7d25106 100644
> > --- a/hw/ppc/mac_newworld.c
> > +++ b/hw/ppc/mac_newworld.c
> > @@ -380,6 +380,7 @@ static void ppc_core99_init(MachineState *machine)
> >           pci_bus = pci_pmac_init(pic, get_system_memory(), get_system_io());
> >           machine_arch = ARCH_MAC99;
> >       }
> > +    object_property_set_bool(OBJECT(pci_bus), true, "realized", &error_abort);
> >
> >       machine->usb |= defaults_enabled() && !machine->usb_disabled;