Re: [Qemu-ppc] [Qemu-devel] [PATCH 01/10] ppc: Fix rfi/rfid/hrfi/... emulation

[Benjamin Herrenschmidt]

        <address@hidden>
        
        
        <address@hidden>
        
        
        <address@hidden> <address@hidden>
        
        
        <address@hidden> <address@hidden>
         <address@hidden>
Organization: IBM Australia
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.20.3 (3.20.3-1.fc24) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit

On Fri, 2016-06-17 at 12:41 +0200, Cédric Le Goater wrote:
> 
> This is too brutal :
> 
> +Â Â Â  /* This instruction doesn't exist anymore on 64-bit server
> +Â Â Â Â  * processors compliant with arch 2.x
> +Â Â Â Â  */
> +Â Â Â  if (ctx->insns_flags & PPC_SEGMENT_64B) {
> +Â Â Â Â Â Â Â  gen_inval_exception(ctx, POWERPC_EXCP_INVAL_INVAL);
> +Â Â Â Â Â Â Â  return;
> +Â Â Â  }
> Â Â Â Â Â Â Â Â 
> 
> There are a couple of instructions which have been deleted from 
> ISA 2.x. rfi is one of them. Could we use a insn_flag to filter
> them  ? 

Why is it too brutal ? We don't really support pre-arch 2.0 64-bit
processors do we ?

Cheers,
Ben.