|
From: | Aurelien Jarno |
Subject: | Re: [Qemu-ppc] [PATCH 1/2] Fix confusing argument names of do_unaligned_access() functions |
Date: | Mon, 13 Jun 2016 09:03:26 +0200 |
User-agent: | Mutt/1.6.0 (2016-04-01) |
On 2016-06-10 19:26, Sergey Sorokin wrote: > There are functions cpu_unaligned_access() and do_unaligned_access() that > are called with access type and mmu index arguments. But these arguments > are named 'is_write' and 'is_user' in their declarations. > The patch fixes the names to avoid a confusion. Unless I missed something, it seems that the is_user/mmu_idx argument is never used. Should we maybe just drop it? Otherwise it looks fine. -- Aurelien Jarno GPG: 4096R/1DDD8C9B address@hidden http://www.aurel32.net
[Prev in Thread] | Current Thread | [Next in Thread] |