Re: [Qemu-ppc] [PATCH v7 10/13] spapr: CPU hotplug support

[David Gibson]

On Thu, Jan 28, 2016 at 11:19:52AM +0530, Bharata B Rao wrote:
> Support CPU hotplug via device-add command like this:
> 
> (qemu) device_add powerpc64-cpu-core,id=core2
> 
> In response to device_add, CPU core device will be created. CPU core
> device creates and realizes CPU thread devices. If the machine type
> supports CPU hotplug, boot-time CPUs are created as CPU core devices
> otherwise they continue to be created as individual CPU devices.
> 
> Set up device tree entries for the hotplugged CPU core and use the
> exising EPOW event infrastructure to send CPU hotplug notification to
> the guest.
> 
> Signed-off-by: Bharata B Rao <address@hidden>

Reviewed-by: David Gibson <address@hidden>

The logic here looks basically sound.  Elswhere however I have
comments on the socket / core / package / whatnot interfaces that I'm
not entirely convinced by.  Changes there are likely to require
changes here, although with luck not too big.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

signature.asc
Description: PGP signature