[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH v8 17/35] qapi: Drop unused 'kind' fo
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH v8 17/35] qapi: Drop unused 'kind' for struct/enum visit |
Date: |
Tue, 5 Jan 2016 15:05:50 +0100 |
Hi
On Mon, Dec 21, 2015 at 6:08 PM, Eric Blake <address@hidden> wrote:
> visit_start_struct() and visit_type_enum() had a 'kind' argument
> that was usually set to either the stringized version of the
> corresponding qapi type name, or to NULL (although some clients
> didn't even get that right). But nothing ever used the argument.
> It's even hard to argue that it would be useful in a debugger,
> as a stack backtrace also tells which type is being visited.
>
> Therefore, drop the 'kind' argument as dead.
>
> Signed-off-by: Eric Blake <address@hidden>
>
Sounds reasonable to me:
Reviewed-by: Marc-André Lureau <address@hidden>
--
Marc-André Lureau
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v8 17/35] qapi: Drop unused 'kind' for struct/enum visit,
Marc-André Lureau <=