qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-ppc] [RFC 00/12] Merge EEH support into spapr-pci-host-bridge


From: David Gibson
Subject: [Qemu-ppc] [RFC 00/12] Merge EEH support into spapr-pci-host-bridge
Date: Thu, 19 Nov 2015 15:29:16 +1100

This series of patches (2 to vfio, the remainder to the sPAPR specific
PCI code) improve the interfaces for passing through EEH (IBM's
Enhanced Error Handling facility) from guest PCI devices to host PCI
devices.

This allows EEH to be used on the normal spapr-pci-host-bridge device,
removing any remaining need for the special spapr-vfio-pci-host-bridge
device.

The series has some similarities to my earlier series merging EEH
support into the plain host bridge, but is substantially reworked to
remove the serious conceptual error I made then.

For now, this only allows EEH when (i) there is a single VFIO
container attached to the vPHB, and (ii) there is only a single VFIO
group attached to that container.

(ii) is due to a kernel limitation - at present it will allow EEH
calls on a container with multiple groups, but they won't work
properly, because there is no code to make sure the EEH state on the
host is synchronized between the groups.

(i) could be addressed in future in one of two ways, either perform
similar synchronization in qemu between the container states, or
present each container as a separate PAPR Partitionable Endpoint to
the guest and allow separate EEH state on each.  The second approach
is more complicated and may not work well with some PAPR addressing
conventions, but does allow more flexibility in the guest.

I hope to have this ready for merge in qemu-2.6.

David Gibson (12):
  vfio: Start improving VFIO/EEH interface
  spapr_pci: Switch to vfio_eeh_as_op() interface
  spapr_pci: Eliminate class callbacks
  spapr_pci: Fold spapr_phb_vfio_eeh_configure() into spapr_pci code
  spapr_pci: Fold spapr_phb_vfio_eeh_reset() into spapr_pci code
  spapr_pci: Fold spapr_phb_vfio_eeh_get_state() into spapr_pci code
  spapr_pci: Fold spapr_phb_vfio_eeh_set_option() into spapr_pci code
  spapr_pci: Fold spapr_phb_vfio_reset() into spapr_pci code
  spapr_pci: Allow EEH on spapr-pci-host-bridge
  spapr_pci: (Mostly) remove spapr-pci-vfio-host-bridge
  spapr_pci: Remove finish_realize hook
  vfio: Eliminate vfio_container_ioctl()

 hw/ppc/spapr_pci.c          | 203 +++++++++++++++++++++++++++---------
 hw/ppc/spapr_pci_vfio.c     | 245 +++-----------------------------------------
 hw/vfio/common.c            |  94 +++++++++++------
 include/hw/pci-host/spapr.h |  28 +----
 include/hw/vfio/vfio.h      |   4 +-
 5 files changed, 235 insertions(+), 339 deletions(-)

-- 
2.5.0




reply via email to

[Prev in Thread] Current Thread [Next in Thread]