[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC PATCH 07/10] spapr_pci: Allow PCI host bridge DMA wi
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-ppc] [RFC PATCH 07/10] spapr_pci: Allow PCI host bridge DMA window to be configured |
|
Date: |
Mon, 5 Oct 2015 16:13:30 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 03/10/2015 02:25, Alexey Kardashevskiy wrote:
>> I think this is the aim of VMSTATE_UINT64_EQUAL() ?
>
> We use it only for things which cannot be set via the command line
> and ideally there should be no VMSTATE_*_EQUAL. If something can be
> set via the command line, then the management software (read -
> libvirt) runs QEMU with explicit parameters to guarantee that these
> are equal.
VMSTATE_*_EQUAL is used when a value is later used as e.g. the size of
an array. It basically provides bounds checking for the subsequent
array, avoiding that an invalid migration file or an error issuing the
QEMU command on the destination transforms into a buffer overflow.
Michael Roth did most of this work, IIRC. Documenting it in
docs/migration.txt would be nice.
Paolo