Re: [Qemu-ppc] [PATCH 19/19] ppc: Rename ELF_MACHINE to be PPC specific

[Alexander Graf]

On 07.09.15 07:04, Peter Crosthwaite wrote:
> On Tue, Aug 18, 2015 at 6:04 PM, Laurent Vivier <address@hidden> wrote:
>> I'm wondering if the existing behavior is good:
>>
>> what I have understood is we define ppc32 guests in ppc64 target to be
>> able to run 32bit guest with 64bit qemu, but I don't think it means an
>> oldworld mac is able to run a ppc64 kernel.
>>
>> So I think we could use directly EM_PPC with e500, ppc440, virtex_ml507,
> 
> Definitely right for virtex_ml507.
> 
>> prep and oldworld, and EM_PPC64 with pseries/spapr. Newworld mac should
>> be able to run EM_PPC and EM_PPC64 kernel (G3/G4 <-> G5), according to
>> the machine type and not to the target.
>>
> 
> Sounds good, can the PPC maintainers give a nod to this idea?
> Otherwise I'd like to run with the patch as is, as the patch as-is is
> non-functional which is the intent of the overall series.

I think the idea is sound, but I'd prefer to see it as a follow-up patch
converting each machine individually. That way bisecting things will be
easier and if we have to revert anything, we only revert the functional
change.


Alex