qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 00/10] Fix machine class names to use


From: Eduardo Habkost
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 00/10] Fix machine class names to use the "-machine" suffix
Date: Wed, 2 Sep 2015 16:58:45 -0300
User-agent: Mutt/1.5.23 (2014-03-12)

Ping?

Andreas, should this go through your QOM tree?

On Thu, Aug 20, 2015 at 02:54:26PM -0700, Eduardo Habkost wrote:
> The machine class names in QEMU are not consistent today. Some of them use the
> "-machine" suffix, but some use completely different naming conventions. This
> makes it difficult to implement machine class lookup without iterating through
> the whole list of machine classes.
> 
> This series changes all machines to use "<machine name>-machine" as the class
> name, so we can simply use object_class_by_name() in the future to lookup
> machine classes. (This was not done yet because it will also require some
> changes in the way aliases are handled.)
> 
> Cc: Alexander Graf <address@hidden>
> Cc: Christian Borntraeger <address@hidden>
> Cc: Cornelia Huck <address@hidden>
> Cc: Peter Maydell <address@hidden>
> Cc: address@hidden
> Cc: Richard Henderson <address@hidden>
> 
> Eduardo Habkost (10):
>   machine: MACHINE_TYPE_NAME macro
>   vexpress: Don't set name on abstract class
>   vexpress: Rename machine classes to use MACHINE_TYPE_NAME
>   arm: Rename virt machine class to use MACHINE_TYPE_NAME
>   pseries: Rename machine class names to use MACHINE_TYPE_NAME
>   s390-virtio: Rename machine class name to use MACHINE_TYPE_NAME
>   s390: Rename s390-ccw-virtio-2.4 class name to use MACHINE_TYPE_NAME
>   mac99: Use MACHINE_TYPE_NAME to encode class name
>   machine: Ensure all TYPE_MACHINE subclasses have the right suffix
>   machine: Set MachineClass::name automatically
> 
>  hw/arm/vexpress.c          |  7 ++-----
>  hw/arm/virt.c              |  4 ++--
>  hw/core/machine.c          | 12 ++++++++++++
>  hw/ppc/mac_newworld.c      |  3 +--
>  hw/ppc/spapr.c             | 12 ++++--------
>  hw/s390x/s390-virtio-ccw.c |  2 +-
>  hw/s390x/s390-virtio.c     |  4 ++--
>  include/hw/boards.h        |  6 ++++++
>  vl.c                       |  3 +--
>  9 files changed, 31 insertions(+), 22 deletions(-)
> 
> -- 
> 2.1.0
> 
> 

-- 
Eduardo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]