Re: [Qemu-ppc] [PATCH 2/4] spapr: Remove obsolete ram_limit field from sPAPRMachineState

[David Gibson]

On Thu, May 07, 2015 at 02:12:58PM +1000, Alexey Kardashevskiy wrote:
> On 05/07/2015 01:57 PM, David Gibson wrote:
> >The ram_limit field was imported from sPAPREnvironment where it predates
> >the machine's ram size being available generically from machine->ram_size.
> >
> >Signed-off-by: David Gibson <address@hidden>
> >---
> >  hw/ppc/spapr.c         | 3 +--
> >  hw/ppc/spapr_hcall.c   | 3 ++-
> >  include/hw/ppc/spapr.h | 1 -
> >  3 files changed, 3 insertions(+), 4 deletions(-)
> >
> >diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> >index 601c41b..1123358 100644
> >--- a/hw/ppc/spapr.c
> >+++ b/hw/ppc/spapr.c
> >@@ -1496,9 +1496,8 @@ static void ppc_spapr_init(MachineState *machine)
> >      }
> >
> >      /* allocate RAM */
> >-    sm->ram_limit = ram_size;
> 
> 
> 
> I had to look at the code to realize that ram_size is local and it can
> actually be removed.

Actually.. it's worse than that.  There's both a global and this local
which was masking it.  Luckily the local had the same value, but it's
still nasty.

Respin will clean this up better.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

pgp5VlgNkxk51.pgp
Description: PGP signature