[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 2/2] sPAPR: Reenable EEH functionality on reboot
From: |
Gavin Shan |
Subject: |
[Qemu-ppc] [PATCH 2/2] sPAPR: Reenable EEH functionality on reboot |
Date: |
Thu, 26 Mar 2015 16:35:02 +1100 |
When rebooting the guest, some PEs might be in frozen state. The
contained PCI devices won't work properly if their frozen states
aren't cleared in time. One case running into this situation would
be maximal EEH error times encountered in the guest.
The patch reenables the EEH functinality on PEs on PHB's reset
callback, which will clear their frozen states if needed.
Signed-off-by: Gavin Shan <address@hidden>
---
hw/ppc/spapr_pci_vfio.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c
index 6fa3afe..25c1b3e 100644
--- a/hw/ppc/spapr_pci_vfio.c
+++ b/hw/ppc/spapr_pci_vfio.c
@@ -71,9 +71,21 @@ static void spapr_phb_vfio_finish_realize(sPAPRPHBState
*sphb, Error **errp)
spapr_tce_get_iommu(tcet));
}
+/*
+ * The PE might be in frozen state. To reenable the EEH
+ * functionality on it will clean the frozen state, which
+ * ensures that the contained PCI devices will work properly.
+ */
static void spapr_phb_vfio_reset(DeviceState *qdev)
{
- /* Do nothing */
+ sPAPRPHBVFIOState *svphb = SPAPR_PCI_VFIO_HOST_BRIDGE(qdev);
+ struct vfio_eeh_pe_op op = {
+ .argsz = sizeof(op),
+ .op = VFIO_EEH_PE_ENABLE
+ };
+
+ vfio_container_ioctl(&svphb->phb.iommu_as,
+ svphb->iommugroupid, VFIO_EEH_PE_OP, &op);
}
static int spapr_phb_vfio_eeh_set_option(sPAPRPHBState *sphb,
--
1.8.3.2
- [Qemu-ppc] [PATCH v3 0/2] Bug fixes for EEH on VFIO PCI devices, Gavin Shan, 2015/03/26
- [Qemu-ppc] [PATCH v3 1/2] VFIO: Clear stale MSIx table during EEH reset, Gavin Shan, 2015/03/26
- Re: [Qemu-ppc] [PATCH v3 1/2] VFIO: Clear stale MSIx table during EEH reset, David Gibson, 2015/03/27
- Re: [Qemu-ppc] [PATCH v3 1/2] VFIO: Clear stale MSIx table during EEH reset, David Gibson, 2015/03/29
- Re: [Qemu-ppc] [PATCH v3 1/2] VFIO: Clear stale MSIx table during EEH reset, Gavin Shan, 2015/03/30
- Re: [Qemu-ppc] [PATCH v3 1/2] VFIO: Clear stale MSIx table during EEH reset, Alex Williamson, 2015/03/31
- Re: [Qemu-ppc] [PATCH v3 1/2] VFIO: Clear stale MSIx table during EEH reset, Gavin Shan, 2015/03/31
- Re: [Qemu-ppc] [PATCH v3 1/2] VFIO: Clear stale MSIx table during EEH reset, Alex Williamson, 2015/03/31
- Re: [Qemu-ppc] [PATCH v3 1/2] VFIO: Clear stale MSIx table during EEH reset, Gavin Shan, 2015/03/31
[Qemu-ppc] [PATCH 2/2] sPAPR: Reenable EEH functionality on reboot,
Gavin Shan <=