[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v5 14/16] pci: make pci_bar useable outside pci.c
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH v5 14/16] pci: make pci_bar useable outside pci.c |
Date: |
Tue, 24 Feb 2015 21:20:40 +1100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Feb 16, 2015 at 08:27:50AM -0600, Michael Roth wrote:
> We need to work with PCI BARs to generate OF properties
> during PCI hotplug for sPAPR guests.
>
> Signed-off-by: Michael Roth <address@hidden>
Added Michael Tsirkin to the Cc list, since he usually handles the PCI
subsystem.
Reviewed-by: David Gibson <address@hidden>
> ---
> hw/pci/pci.c | 2 +-
> include/hw/pci/pci.h | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index d508930..f37d3e1 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -123,7 +123,7 @@ static uint16_t pci_default_sub_device_id =
> PCI_SUBDEVICE_ID_QEMU;
>
> static QLIST_HEAD(, PCIHostState) pci_host_bridges;
>
> -static int pci_bar(PCIDevice *d, int reg)
> +int pci_bar(PCIDevice *d, int reg)
> {
> uint8_t type;
>
> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
> index 97a83d3..eba9200 100644
> --- a/include/hw/pci/pci.h
> +++ b/include/hw/pci/pci.h
> @@ -330,6 +330,7 @@ void pci_device_save(PCIDevice *s, QEMUFile *f);
> int pci_device_load(PCIDevice *s, QEMUFile *f);
> MemoryRegion *pci_address_space(PCIDevice *dev);
> MemoryRegion *pci_address_space_io(PCIDevice *dev);
> +int pci_bar(PCIDevice *d, int reg);
>
> typedef void (*pci_set_irq_fn)(void *opaque, int irq_num, int level);
> typedef int (*pci_map_irq_fn)(PCIDevice *pci_dev, int irq_num);
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpUYkYK1dUkN.pgp
Description: PGP signature
- Re: [Qemu-ppc] [PATCH v5 10/16] spapr_drc: add spapr_drc_populate_dt(), (continued)
- [Qemu-ppc] [PATCH v5 09/16] spapr_events: event-scan RTAS interface, Michael Roth, 2015/02/16
- [Qemu-ppc] [PATCH v5 13/16] spapr_pci: populate DRC dt entries for PHBs, Michael Roth, 2015/02/16
- [Qemu-ppc] [PATCH v5 15/16] spapr_pci: enable basic hotplug operations, Michael Roth, 2015/02/16
- [Qemu-ppc] [PATCH v5 01/16] docs: add sPAPR hotplug/dynamic-reconfiguration documentation, Michael Roth, 2015/02/16
- [Qemu-ppc] [PATCH v5 14/16] pci: make pci_bar useable outside pci.c, Michael Roth, 2015/02/16
- Re: [Qemu-ppc] [PATCH v5 14/16] pci: make pci_bar useable outside pci.c,
David Gibson <=
- [Qemu-ppc] [PATCH v5 16/16] spapr_pci: emit hotplug add/remove events during hotplug, Michael Roth, 2015/02/16
- [Qemu-ppc] [PATCH v5 11/16] spapr_pci: add dynamic-reconfiguration option for spapr-pci-host-bridge, Michael Roth, 2015/02/16
- [Qemu-ppc] [PATCH v5 12/16] spapr_pci: create DRConnectors for each PCI slot during PHB realize, Michael Roth, 2015/02/16
- [Qemu-ppc] [PATCH v5 04/16] spapr_rtas: add set-indicator RTAS interface, Michael Roth, 2015/02/16
- [Qemu-ppc] [PATCH v5 02/16] spapr_drc: initial implementation of sPAPRDRConnector device, Michael Roth, 2015/02/16
- [Qemu-ppc] [PATCH v5 06/16] spapr: add rtas_st_buffer_direct() helper, Michael Roth, 2015/02/16
- [Qemu-ppc] [PATCH v5 03/16] spapr_rtas: add get/set-power-level RTAS interfaces, Michael Roth, 2015/02/16