Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/3] Create specific config option for "platform-bus"

[Peter Crosthwaite]

On Mon, Feb 23, 2015 at 3:05 PM, David Gibson
<address@hidden> wrote:
> Currently the "platform-bus" device is included for all softmmu builds.
> This bridge is intended for use on any platforms that require dynamic
> creation of sysbus devices.  However, at present it is used only for the
> PPC E500 target, with plans for the ARM "virt" target in the immediate
> future.
>
> To avoid a not-very-useful entry appearing in "qemu -device ?" output on
> other targets, this patch makes a specific config option for platform-bus
> and enables it (for now) only on ppc configurations which include E500
> and on ARM (which always includes the "virt" target).
>
> Signed-off-by: David Gibson <address@hidden>
> ---
>  default-configs/arm-softmmu.mak   | 1 +
>  default-configs/ppc-softmmu.mak   | 1 +
>  default-configs/ppc64-softmmu.mak | 1 +
>  hw/core/Makefile.objs             | 2 +-
>  4 files changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 6ee9b43..cc2745f 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -79,6 +79,7 @@ CONFIG_NSERIES=y
>  CONFIG_REALVIEW=y
>  CONFIG_ZAURUS=y
>  CONFIG_ZYNQ=y
> +CONFIG_PLATFORM_BUS=y
>

This location might not fit best for this config. REALVIEW, and ZYNQ
are ARM specific boards and this logical grouping of configs seems to
be about ARM boards and their specific devs.

Should it just be in it's own category? Alternatively, the first block
of configs seems to contain all the generic stuff (like SSI, SD,
SERIAL and pci.mak) so I think it fits in that bucket most closely.

Regards,
Peter

>  CONFIG_VERSATILE_PCI=y
>  CONFIG_VERSATILE_I2C=y
> diff --git a/default-configs/ppc-softmmu.mak b/default-configs/ppc-softmmu.mak
> index aebfab9..4b60e69 100644
> --- a/default-configs/ppc-softmmu.mak
> +++ b/default-configs/ppc-softmmu.mak
> @@ -43,6 +43,7 @@ CONFIG_PREP=y
>  CONFIG_MAC=y
>  CONFIG_E500=y
>  CONFIG_OPENPIC_KVM=$(and $(CONFIG_E500),$(CONFIG_KVM))
> +CONFIG_PLATFORM_BUS=y
>  CONFIG_ETSEC=y
>  CONFIG_LIBDECNUMBER=y
>  # For PReP
> diff --git a/default-configs/ppc64-softmmu.mak 
> b/default-configs/ppc64-softmmu.mak
> index f195a87..de71e41 100644
> --- a/default-configs/ppc64-softmmu.mak
> +++ b/default-configs/ppc64-softmmu.mak
> @@ -44,6 +44,7 @@ CONFIG_PREP=y
>  CONFIG_MAC=y
>  CONFIG_E500=y
>  CONFIG_OPENPIC_KVM=$(and $(CONFIG_E500),$(CONFIG_KVM))
> +CONFIG_PLATFORM_BUS=y
>  CONFIG_ETSEC=y
>  CONFIG_LIBDECNUMBER=y
>  # For pSeries
> diff --git a/hw/core/Makefile.objs b/hw/core/Makefile.objs
> index 9dce1bc..abb3560 100644
> --- a/hw/core/Makefile.objs
> +++ b/hw/core/Makefile.objs
> @@ -14,4 +14,4 @@ common-obj-$(CONFIG_SOFTMMU) += machine.o
>  common-obj-$(CONFIG_SOFTMMU) += null-machine.o
>  common-obj-$(CONFIG_SOFTMMU) += loader.o
>  common-obj-$(CONFIG_SOFTMMU) += qdev-properties-system.o
> -common-obj-$(CONFIG_SOFTMMU) += platform-bus.o
> +common-obj-$(CONFIG_PLATFORM_BUS) += platform-bus.o
> --
> 2.1.0
>
>