[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] openpic: convert to vmstate
From: |
Mark Cave-Ayland |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] openpic: convert to vmstate |
Date: |
Mon, 09 Feb 2015 20:05:14 +0000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 |
On 09/02/15 13:50, Juan Quintela wrote:
> Mark Cave-Ayland <address@hidden> wrote:
>> On 09/02/15 12:43, Alexander Graf wrote:
>
>> Ha! I did actually do this but I accidentally messed up a rebase just
>> before sending out the patchset so it got lost. But yes, I agree a
>> version bump to 3 should be sufficient here.
>>
>> Just to put this in context: before the PPC loadvm/savevm patchset was
>> posted to the list, I was bisecting down to around the 0.10-0.11
>> timeframe to figure out where things broke, and even then the Mac
>> machines wouldn't run correctly after loadvm. So I agree with Alex that
>> any snapshots this old would be useless anyway.
>>
>> Based upon this, are there any other changes you would like before a respin?
>
> I didn't knew that it was completely broken (TM).
>
> As said in a different email, I think that using the _EQUAL() macro for
> nb_cpus is a good idea. For the rest, I agree with it.
Great, thanks! I'll make the changes, add your Reviewed-by and then
re-spin out the complete patchset for Alex.
ATB,
Mark.
Re: [Qemu-ppc] [PATCH 0/2] openpic: convert to vmstate, Alexander Graf, 2015/02/06