Re: [Qemu-ppc] [Qemu-devel] [PATCH 0/7] ppc: loadvm/savevm fixups for -M g3beige and -M mac99

[Programmingkid]

On Jan 21, 2015, at 7:34 AM, Mark Cave-Ayland wrote:

> On 20/01/15 19:26, Programmingkid wrote:
> 
>>> Ping? Particularly patches 4 and 5 will require some review as they fix
>>> general target-ppc bugs when loading/saving VM state and aren't just
>>> specific to the g3beige/mac99 machines.
>> 
>> I decided to try them out. Using Mac OS 10.2 in the guest, I opened up a
>> word processor and saved the state of QEMU. I then quit QEMU and started
>> it back up. When the state was loaded, the screen looked exactly how it
>> should, but nothing was working. QEMU was frozen. It was using around
>> 100% of the CPU time, so it might have been stuck in some kind of loop.
>> Once when I tried loading a saved state, it did work. Haven't been able
>> to reproduce it after several attempts. 
>> 
>> I suggest you use a fully installed guest OS for testing. Debian Linux 5
>> is good. 
>> 
>> Just to note, I used QEMU 2.2.0 for testing.
> 
> Thanks for testing. Please remember the patch was designed to try and
> help me locate a macio regression in a single-user mode installer
> environment, and so I would be very surprised if it were safe for use in
> a full OS with background disk access. Apologies if that wasn't overly
> clear from the cover letter.
> 
> I did have some further patches that gave me some success during active
> disk I/O but I haven't focused on them, primarily because there are
> other outstanding bugs in the macio alignment code.
> 
> At the very least it should be possible to loadvm/savevm from within an
> OpenBIOS Forth session consistently without crashing under both -M
> g3beige and -M mac99 which was my test case for this patchset.

I do think your work has a lot of promise to it. Many would benefit if you did
continue to improve the save states for the PPC emulator.