Re: [Qemu-ppc] [PATCH 1/5] target-ppc: Extend rtas-blob

[Alexander Graf]

> Am 29.08.2014 um 03:06 schrieb Benjamin Herrenschmidt <address@hidden>:
> 
>> On Fri, 2014-08-29 at 02:40 +0200, Alexander Graf wrote:
>> 
>>> On 29.08.14 00:25, Benjamin Herrenschmidt wrote:
>>>> On Fri, 2014-08-29 at 00:18 +0200, Alexander Graf wrote:
>>>> I strongly disagree with David. Legally there is no difference between a
>>>> .bin file that contains code and an array made of instructions. And the
>>>> more target code we can keep outside of QEMU the better.
>>> 
>>> Ugh ... having a separate file with it's own build system etc... for 5
>>> instructions is borderline ridiculous too :-)
>> 
>> Then don't use it - nobody's forcing you to do so :). Just use the
>> provided binary. I fail to see the difference between
>> 
>>  uint32_t rtas_blob[] = { INST_SC1, INST_BLR };
>> 
>> and
>> 
>>  uint32_t *rtas_blob;
>>  load_file_from_disk(rtas_blob);
>> 
>> except that we're using an actual assembler ;).
> 
> So you fail to see the difference with an array of 5 words vs. running
> through thousands of instructions & syscall to read those same 5 words
> from disk ? :-)

I fail to see a problem, yeah :). Imagine the same thing on x86 with its 
completely messed up instruction set. Would you still advocate for in-qemu code 
or would you prefer to have a compiler between you and the ugly opcodes?


Alex