Re: [Qemu-ppc] [Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support

[Alexey Kardashevskiy]

On 06/04/2014 07:50 PM, Alexander Graf wrote:
> 
> On 04.06.14 11:47, Peter Maydell wrote:
>> On 4 June 2014 10:39, Paolo Bonzini <address@hidden> wrote:
>>> It's a kind of "emergency button" on real machines.  On PCs it sends an NMI
>>> and this results in some kind of crash dump if the OS is configured
>>> appropriately.  The command may be ill-named for historical reasons, but
>>> the
>>> effect is not x86-specific.
>> OK, so our callback function name should be sensibly named
>> to match what the effect is supposed to be, and we should have
>> a sensibly named command, and we should make "nmi" be
>> a historical-legacy-backwards-compatibility command alias
>> (possibly only exposed for x86).
> 
> I honestly don't have a better name :).

Worse name? Any name? If we come up with some name, "nmi" will still do
"restart" on s390, won't it (backward compatibility blablabla)? So there is
no point adding it for anyone but PPC64 and therefore it can be something
like "machinecheck" and we'll have yet another #ifdef in cpus.c. Which
would be very unusual and very awesome as I am normally not allowed to do
ppc-hacks in generic code :-D



-- 
Alexey