Re: [Qemu-ppc] [PATCH v4 16/29] target-ppc: Make use of gen_spr_book3s_lpar() for POWER7/8

[Tom Musta]

On 6/3/2014 4:27 AM, Alexey Kardashevskiy wrote:
> This makes use of generic gen_spr_book3s_lpar() which registers LPCR SPR.
> 
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
> ---
>  target-ppc/translate_init.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index 40c8ce1..bc68adb 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -7800,13 +7800,9 @@ static void init_proc_POWER7 (CPUPPCState *env)
>      gen_spr_book3s_common(env);
>      gen_spr_power5p_common(env);
>      gen_spr_power6_common(env);
> +    gen_spr_book3s_lpar(env);
>      gen_spr_power6_dbg(env);
>      gen_spr_amr(env);
> -    /* Logical partitionning */
> -    spr_register_kvm(env, SPR_LPCR, "LPCR",
> -                     SPR_NOACCESS, SPR_NOACCESS,
> -                     &spr_read_generic, &spr_write_generic,
> -                     KVM_REG_PPC_LPCR, 0x00000000);
>  #if !defined(CONFIG_USER_ONLY)
>      env->slb_nr = 32;
>  #endif
> 

Reviewed-by: Tom Musta <address@hidden>