Re: [Qemu-ppc] [PATCH v4 6/6] PPC 85xx: Add qemu-ppce500 machine

[York Sun]

On 04/28/2014 02:27 PM, Alexander Graf wrote:
>> I am thinking to add back "#ifdef CONFIG_QEMU_E500" you had for your v3 and
>> earlier version for the above change. Do you have any concerns?
>>
>> The reason I am proposing this is to use generic board architecture.
>> gd->fdt_blob is used by some other functions to detect if device tree exists.
>> Your change takes r3 from entry and treat it as device tree. It is not the 
>> case
>> for a normal metal SoC. I need to clear this variable.
> 
> No complaints at all from me here :)
> 

Thanks. I will submit a patch to fix it.

York