[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH v2 11/12] hw/intc/xilinx_intc: Avoid shifting left int
From: |
Peter Maydell |
Subject: |
[Qemu-ppc] [PATCH v2 11/12] hw/intc/xilinx_intc: Avoid shifting left into sign bit |
Date: |
Mon, 17 Mar 2014 16:00:40 +0000 |
Avoid undefined behaviour shifting left into the sign bit.
Signed-off-by: Peter Maydell <address@hidden>
---
hw/intc/xilinx_intc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c
index 4a10398..1b228ff 100644
--- a/hw/intc/xilinx_intc.c
+++ b/hw/intc/xilinx_intc.c
@@ -71,8 +71,9 @@ static void update_irq(struct xlx_pic *p)
/* Update the vector register. */
for (i = 0; i < 32; i++) {
- if (p->regs[R_IPR] & (1 << i))
+ if (p->regs[R_IPR] & (1U << i)) {
break;
+ }
}
if (i == 32)
i = ~0;
--
1.9.0
- [Qemu-ppc] [PATCH v2 00/12] Avoid shifting left into sign bit, Peter Maydell, 2014/03/17
- [Qemu-ppc] [PATCH v2 12/12] hw/pci-host/apb.c: Avoid shifting left into sign bit, Peter Maydell, 2014/03/17
- [Qemu-ppc] [PATCH v2 11/12] hw/intc/xilinx_intc: Avoid shifting left into sign bit,
Peter Maydell <=
- [Qemu-ppc] [PATCH v2 07/12] hw/intc/openpic: Avoid shifting left into sign bit, Peter Maydell, 2014/03/17
- [Qemu-ppc] [PATCH v2 02/12] hw/intc/apic.c: Use uint32_t for mask word in foreach_apic, Peter Maydell, 2014/03/17
- [Qemu-ppc] [PATCH v2 03/12] hw/pci/pci_host.c: Avoid shifting left into sign bit, Peter Maydell, 2014/03/17
- [Qemu-ppc] [PATCH v2 10/12] hw/intc/slavio_intctl: Avoid shifting left into sign bit, Peter Maydell, 2014/03/17
- [Qemu-ppc] [PATCH v2 04/12] hw/i386/acpi_build.c: Avoid shifting left into sign bit, Peter Maydell, 2014/03/17
- [Qemu-ppc] [PATCH v2 09/12] tests/libqos/pci-pc: Avoid shifting left into sign bit, Peter Maydell, 2014/03/17
- [Qemu-ppc] [PATCH v2 01/12] target-i386: Avoid shifting left into sign bit, Peter Maydell, 2014/03/17
- [Qemu-ppc] [PATCH v2 06/12] hw/usb/hcd-ohci.c: Avoid shifting left into sign bit, Peter Maydell, 2014/03/17
- [Qemu-ppc] [PATCH v2 08/12] hw/ppc: Avoid shifting left into sign bit, Peter Maydell, 2014/03/17
- [Qemu-ppc] [PATCH v2 05/12] target-mips: Avoid shifting left into sign bit, Peter Maydell, 2014/03/17