[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 2/4] moxie: fix load_elf() usage
From: |
Alexander Graf |
Subject: |
Re: [Qemu-ppc] [PATCH 2/4] moxie: fix load_elf() usage |
Date: |
Fri, 31 Jan 2014 08:18:01 +0100 |
On 22.01.2014, at 06:20, Alexey Kardashevskiy <address@hidden> wrote:
> At the moment in the case of error, load_elf() returns -1 so load_kernel()
> will not signal error at all.
>
> Signed-off-by: Alexey Kardashevskiy <address@hidden>
Anthony (Green), could you please ack this patch?
Alex
> ---
> hw/moxie/moxiesim.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/moxie/moxiesim.c b/hw/moxie/moxiesim.c
> index ef4f3a8..a87ca6d 100644
> --- a/hw/moxie/moxiesim.c
> +++ b/hw/moxie/moxiesim.c
> @@ -55,7 +55,7 @@ static void load_kernel(MoxieCPU *cpu, LoaderParams
> *loader_params)
> &entry, &kernel_low, &kernel_high, 1,
> ELF_MACHINE, 0);
>
> - if (!kernel_size) {
> + if (kernel_size <= 0) {
> fprintf(stderr, "qemu: could not load kernel '%s'\n",
> loader_params->kernel_filename);
> exit(1);
> --
> 1.8.4.rc4
>