[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v3 6/6] target-ppc: demonstrate new "vsx" property
From: |
Andreas Färber |
Subject: |
Re: [Qemu-ppc] [PATCH v3 6/6] target-ppc: demonstrate new "vsx" property |
Date: |
Thu, 14 Nov 2013 17:04:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
Am 14.11.2013 06:20, schrieb Alexey Kardashevskiy:
> On 11/12/2013 12:31 AM, Andreas Färber wrote:
>> 2) Please move the array out of the function to just before the
>> containing function.
>
> Again, this is just to show. But. Why do you want those properties to be
> outside of the function? Less visibility is usually a good thing, no?
We used to have ->props = (...[]) {...}; and Anthony specifically
refactored it to have a static variable one level down, just before the
function assigning it. It was a scripted conversion in the context of
QOM introduction, maybe the archives will give you insight about why
exactly it was done.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- Re: [Qemu-ppc] [PATCH v3 5/6] bitops: add BITNR macro, (continued)
- Re: [Qemu-ppc] [PATCH v3 5/6] bitops: add BITNR macro, Andreas Färber, 2013/11/11
- Re: [Qemu-ppc] [PATCH v3 5/6] bitops: add BITNR macro, Alexey Kardashevskiy, 2013/11/11
- Re: [Qemu-ppc] [PATCH v3 5/6] bitops: add BITNR macro, Alexey Kardashevskiy, 2013/11/12
- Re: [Qemu-ppc] [PATCH v3 5/6] bitops: add BITNR macro, Paolo Bonzini, 2013/11/13
- Re: [Qemu-ppc] [PATCH v3 5/6] bitops: add BITNR macro, Alexey Kardashevskiy, 2013/11/14
- Re: [Qemu-ppc] [PATCH v3 5/6] bitops: add BITNR macro, Paolo Bonzini, 2013/11/14
[Qemu-ppc] [PATCH v3 2/6] target-ppc: make use of new -cpu suboptions handling, Alexey Kardashevskiy, 2013/11/11
[Qemu-ppc] [PATCH v3 6/6] target-ppc: demonstrate new "vsx" property, Alexey Kardashevskiy, 2013/11/11