[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DE

From: Benjamin Herrenschmidt
Subject: Re: [Qemu-ppc] [PATCH v3 1/8] target-ppc: Add helper for KVM_PPC_RTAS_DEFINE_TOKEN
Date: Sat, 31 Aug 2013 08:19:47 +1000

On Fri, 2013-08-30 at 16:34 +0200, Alexander Graf wrote:

> > So - kvmppc_define_rtas_in_kernel() or kvmppc_define_rtas_kernel_token()?
> The former probably.

I told him the latter :-) Honestly, your name is gross :-) Mine
describes exactly what the calls does.

> > I would actually though that the very first "k" is for "Kernel" already 
> > but...
> I a symmetric API you could also remove rtas handling from the kernel, so you 
> could tell the kernel "handle this in kernel space" and "don't handle this in 
> kernel space". Our naming needs to be precise enough that you can guess what 
> is going on from it.

But that's not quite what the API is doing and we don't want a symetric
API it's pointless.

Yet another "my CS teacher told me a good API is symetric" (oh and
that's a nice word "symetric", it sounds *good*, using it makes it
look like we are plenty smart !) but in the end totally pointless
for the problem at hand.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]