[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 3/8] vfio: Introduce VFIO address spaces

From: Paolo Bonzini
Subject: Re: [Qemu-ppc] [PATCH 3/8] vfio: Introduce VFIO address spaces
Date: Mon, 19 Aug 2013 15:15:39 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8

Il 13/08/2013 00:07, Alex Williamson ha scritto:
>> > +    if (pci_iommu_as(pdev) != &address_space_memory) {
>> > +        error_report("vfio: DMA address space must be system memory");
>> > +        return -ENXIO;
> -EFAULT?  It's a bad address of sorts.

Accessing it would SIGSEGV, so it is not really EFAULT.  I would just
use EINVAL, the numeric error code will go away as soon as initfn is
changed to use "Error *" (which is needed to propagate sensible error
messages to the QMP client).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]