Re: [Qemu-ppc] [Qemu-devel] [PATCH RFT qom-cpu for-next] gdbstub: Fix gdb_register_coprocessor() register counting

[Andreas Färber]

Am 12.08.2013 19:22, schrieb Andreas Färber:
> Commit a0e372f0c49ac01faeaeb73a6e8f50e8ac615f34 reorganized the register
> counting for GDB. While it seems correct not to let the total number of
> registers skyrocket in an SMP scenario through a static variable, the
> distinction between total register count and 'g' packet register count
> (last_reg vs. num_g_regs) got lost among the way.
> 
> Fix this by introducing CPUState::gdb_num_g_regs and using that in
> gdb_handle_packet().
> 
> Reported-by: Aneesh Kumar K.V <address@hidden>
> Cc: address@hidden (for 1.6)
> Cc: Peter Maydell <address@hidden>
> Cc: Max Filippov <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
>  gdbstub.c         | 6 ++++--
>  include/qom/cpu.h | 2 ++
>  qom/cpu.c         | 2 +-
>  3 files changed, 7 insertions(+), 3 deletions(-)

Ping!

Peter, could you verify the ARM FP registers are now as expected?

Max, could you test xtensa as the special case?

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg