Re: [Qemu-ppc] commit 08521e2 breaks SLOF usb boot

[Alexey Kardashevskiy]

On 07/19/2013 11:03 PM, Paolo Bonzini wrote:
> Il 19/07/2013 14:58, Alexey Kardashevskiy ha scritto:
>> On 07/19/2013 10:50 PM, Paolo Bonzini wrote:
>>> Il 14/06/2013 12:32, Nikunj A Dadhania ha scritto:
>>>> Nikunj A Dadhania <address@hidden> writes:
>>>>> commit 08521e28c7e6e8cc1f53424a0f845f58d2ed9546
>>>>> Author: Paolo Bonzini <address@hidden>
>>>>> Date:   Fri May 24 12:54:01 2013 +0200
>>>>>
>>>>>     memory: add big endian support to access_with_adjusted_size
>>>>>     
>>>>>     This will be used to split 8-byte access down to two four-byte 
>>>>> accesses.
>>>>>     
>>>>>     Reviewed-by: Richard Henderson <address@hidden>
>>>>>     Signed-off-by: Paolo Bonzini <address@hidden>
>>>>>
>>>>>
>>>>> If I hack the above funniness in my USB EHCI driver, somewhere down the
>>>>> qemu crashes at code introduced by this patch:
>>>>>
>>>>> Program received signal SIGSEGV, Segmentation fault.
>>>>> 0x0000000000000000 in ?? ()
>>>>> (gdb) bt
>>>>> #0 0x0000000000000000 in ?? ()
>>>>> #1 0x00005555557a0ea4 in access_with_adjusted_size (address@hidden, 
>>>>> address@hidden, address@hidden, access_size_min=<optimized out>, 
>>>>> access_size_max=<optimized out>,
>>>>> access=0x5555557a1f80 <memory_region_oldmmio_write_accessor>, 
>>>>> opaque=0x5555567f8ab8) at /home/nikunj/work/power/code/qemu/memory.c:396
>>>>> #2 0x00005555557a5ebb in memory_region_dispatch_write (size=1, data=0, 
>>>>> addr=12, mr=0x5555567f8ab8) at 
>>>>> /home/nikunj/work/power/code/qemu/memory.c:998
>>>>>
>>>>> Reverting this, I can safely boot using a usb-storage device put on ehci 
>>>>> controller.
>>>>
>>>> Just reverting this patch does not help though, i will need to figure
>>>> which all commits are bad.
>>>
>>> Hi Nikunj,
>>>
>>> can you try the attached patch?
>>>
>>> Alexey, with some luck it may even fix virtio-blk too.
>>
>>
>> Heh. Bad luck. The behaviour has changed slightly but it still does not work.
> 
> How changed?


See below. I am trying to debug :)


SLOF **********************************************************************
QEMU Starting
 Build Date = Apr 30 2013 14:04:00
 FW Version = git-8cfdfc43f4c4c8c8
 Press "s" to enter Open Firmware.

Populating /vdevice methods
Populating /vdevice/address@hidden

NVRAM: size=65536, fetch=200E, store=200F
Populating /vdevice/address@hidden
Populating /address@hidden
 Adapters on 0800000020000000
                     00 0000 (D) : 1af4 1001    virtio [ block ]
No NVRAM common partition, re-initializing...
claim failed!
Using default console: /vdevice/address@hidden

  Welcome to Open Firmware

  Copyright (c) 2004, 2011 IBM Corporation All rights reserved.
  This program and the accompanying materials are made available
  under the terms of the BSD License available at
  http://www.opensource.org/licenses/bsd-license.php


Trying to load:  from: disk ... qemu-system-ppc64: Guest moved used index
from 0 to 65535



-- 
Alexey