Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

[Fabien Chouteau]

On 07/16/2013 03:06 AM, Peter Crosthwaite wrote:
>>>> +
>>>> +    memory_region_init_io(&etsec->io_area, OBJECT(etsec), &etsec_ops, 
>>>> etsec,
>>>> +                          "eTSEC", 0x1000);
>>>
>>> Constant size memory_region_init_io should be migrated to the Object::Init 
>>> fm.
>>>
>>
>> What is Object::Init()? Do you have an example?
>>
> 
> hw/dma/xilinx_axidma.c - xilinx_axidma_init() and
> xilinx_axidma_realize() has an example of splitting init task between
> early and late. Note the memory_region_init_io is in the _init.
> 

OK thanks,

-- 
Fabien Chouteau