[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 0/6] Clean up bogus default boot order
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-ppc] [PATCH 0/6] Clean up bogus default boot order |
Date: |
Fri, 14 Jun 2013 14:11:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Alexander Graf <address@hidden> writes:
> On 14.06.2013, at 13:40, Markus Armbruster wrote:
>
>> This is on top of "[PATCH v3 00/16] -boot and -no-fd-bootchk fixes",
>> so it's protected by the tests there.
>>
>> The first five patches are admittedly related to the stated purpose of
>> this series pretty much only by "I can't stand perpetuating this
>> stupid crap". Max Filippov and Peter Maydell already cleaned up
>> Xtensa and ARM the same way.
>
> PPC patches are:
>
> Acked-by: Alexander Graf <address@hidden>
>
> As for the functional change of defaulting boot_order to NULL on most
> boards, I'm reasonably indifferent. I suppose the purpose of the
> rename was to detect all cases where it gets used, so it _should_ be
> safe to default to NULL.
Exactly! The rename forces me to examine every machine that actually
uses the default boot order. I null the default only for machines that
don't.
Apart from that, the rename also makes names more consistent :)
- [Qemu-ppc] [PATCH 0/6] Clean up bogus default boot order, Markus Armbruster, 2013/06/14
- [Qemu-ppc] [PATCH 4/6] ppc: Don't explode QEMUMachineInitArgs into local variables needlessly, Markus Armbruster, 2013/06/14
- [Qemu-ppc] [PATCH 1/6] pc: Don't prematurely explode QEMUMachineInitArgs, Markus Armbruster, 2013/06/14
- [Qemu-ppc] [PATCH 2/6] pc: Don't explode QEMUMachineInitArgs into local variables needlessly, Markus Armbruster, 2013/06/14
- [Qemu-ppc] [PATCH 5/6] ppc: Don't duplicate QEMUMachineInitArgs in PPCE500Params, Markus Armbruster, 2013/06/14
- [Qemu-ppc] [PATCH 3/6] sun4: Don't prematurely explode QEMUMachineInitArgs, Markus Armbruster, 2013/06/14
- [Qemu-ppc] [PATCH 6/6] hw: Clean up bogus default boot order, Markus Armbruster, 2013/06/14
- Re: [Qemu-ppc] [PATCH 0/6] Clean up bogus default boot order, Alexander Graf, 2013/06/14
- Re: [Qemu-ppc] [PATCH 0/6] Clean up bogus default boot order,
Markus Armbruster <=