Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] e600 core for MPC86xx processors

[Scott Wood]

On 06/06/2013 06:44:31 AM, Andreas Färber wrote:
> Am 26.05.2013 19:41, schrieb Julio Guerra:
> > MPC86xx processors are based on the e600 core, which is not the case
> > in qemu where it is based on the 7400 processor.
> >
> > This patch creates the e600 core and instantiates the MPC86xx
> > processors based on it. Therefore, adding the high BATs and the SPRG
> > 4..7 registers, which are e600-specific [1].
> >
> > This allows to define the MPC8610 processor too and my program  
> running
> > on a real MPC8610 target is now able to run on qemu :)
> >
> > [1]  
> http://cache.freescale.com/files/32bit/doc/ref_manual/E600CORERM.pdf
> >
> > Signed-off-by: Julio Guerra <address@hidden>
> > ---
> >  target-ppc/cpu-models.c     |  10 ++--
> >  target-ppc/cpu-models.h     |   4 +-
> >  target-ppc/translate_init.c | 122  
> ++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 127 insertions(+), 9 deletions(-)
>
> >From a technical (QOM) view this patch looks fine.
>
> However I can't judge whether all that code is right for e600 and
> whether you may want to share some code with e500 / e5500 in some way?
> CC'ing some Freescale folks.

e600 is a very different core from e500/e5500.  It is a 74xx  
derivative.  The only thing I can see that could be shared with e500 is  
the code to register SPRG4-7, but that's something that's already  
duplicated between a bunch of cores.

-Scott