[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2] Added uapi directory into linux-header
From: |
Bhushan Bharat-R65777 |
Subject: |
Re: [Qemu-ppc] [PATCH v2] Added uapi directory into linux-header |
Date: |
Tue, 18 Dec 2012 10:19:13 +0000 |
> >>>>>>> +++ b/scripts/update-linux-headers.sh
> >>>>>>> @@ -46,14 +46,26 @@ for arch in $ARCHLIST; do
> >>>>>>>
> >>>>>>> make -C "$linux" INSTALL_HDR_PATH="$tmpdir" SRCARCH=$arch
> >>>>>>> headers_install
> >>>>>>>
> >>>>>>> + if [ -e "$linux/arch/$arch/include/uapi" ] &&
> >>>>>>> + ! [ -e "$output/linux-headers/uapi" ] ; then
> >>>>>>> + mkdir "$output/linux-headers/uapi"
> >>>>>>
> >>>>>> mkdir -p
> >>>>>>
> >>>>>> But looking through this whole thing, it seems like the root
> >>>>>> cause is actually different. We don't want any uapi directories
> >>>>>> exposed to user space. So let's go back a step:
> >>>>>>
> >>>>>> Why do we need the uapi include dir? Because some header is using it.
> >>>>>>
> >>>>>> linux-headers/asm-powerpc/kvm_para.h:
> >>>>>
> >>>>> The kvm_para.h (also kvm.h) are now defined in include/uapi/asm/
> >>>>>
> >>>>> Is not this the correct thing that any header file in
> >>>>> include/uapi/asm/ (in
> >>>> this case kvm_para.h) includes another header file (epapr_hcalls.h)
> >>>> in same directory?
> >>>>>
> >>>>> Also I think now only the uapi/asm/*.h files should be exposed to
> >>>>> userspace
> >>>> (QEMU here).
> >>>>
> >>>> make headers_install should basically remove all the uapi magic and
> >>>> give us normal backwards-compatible asm trees :).
> >>>
> >>> I am perfectly fine, How we can do this now :)
> >>
> >> Well, for starters, do the headers work if you apply the patch I sent
> >> in a previous mail plus the epapr_hcall.h copy? If so, then that's
> >> the way to go :)
> >
> > Are you really sure that applying a patch and then syncing (or other way
> round) is the way you want to go ?
>
> Yes, because I'm quite confident we're generating broken headers right now.
Ok, so every time someone does the sync he/she has to do this? Also do we think
that sometime in future this will be taken care by make header_install?
Thanks
-Bharat
>
> Alex
>
> >
> > To me it does not look good, I think we can go with the script changes to
> > make
> install_header is updated to do the work.
> >
> > -Bharat
> >
> >>
> >>
> >> Alex
> >>
> >
> >
- [Qemu-ppc] [PATCH v2] Added uapi directory into linux-header, Bharat Bhushan, 2012/12/17
- Re: [Qemu-ppc] [PATCH v2] Added uapi directory into linux-header, Alexander Graf, 2012/12/17
- Re: [Qemu-ppc] [PATCH v2] Added uapi directory into linux-header, Bhushan Bharat-R65777, 2012/12/17
- Re: [Qemu-ppc] [PATCH v2] Added uapi directory into linux-header, Alexander Graf, 2012/12/17
- Re: [Qemu-ppc] [PATCH v2] Added uapi directory into linux-header, Bhushan Bharat-R65777, 2012/12/17
- Re: [Qemu-ppc] [PATCH v2] Added uapi directory into linux-header, Alexander Graf, 2012/12/17
- Re: [Qemu-ppc] [PATCH v2] Added uapi directory into linux-header, Bhushan Bharat-R65777, 2012/12/17
- Re: [Qemu-ppc] [PATCH v2] Added uapi directory into linux-header, Alexander Graf, 2012/12/18
- Re: [Qemu-ppc] [PATCH v2] Added uapi directory into linux-header,
Bhushan Bharat-R65777 <=
- Re: [Qemu-ppc] [PATCH v2] Added uapi directory into linux-header, Alexander Graf, 2012/12/18
Re: [Qemu-ppc] [PATCH v2] Added uapi directory into linux-header, David Howells, 2012/12/18
Re: [Qemu-ppc] [PATCH v2] Added uapi directory into linux-header, David Howells, 2012/12/18