[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb
From: |
Peter Maydell |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN |
Date: |
Tue, 20 Nov 2012 09:53:53 +0000 |
On 20 November 2012 09:29, Alexander Graf <address@hidden> wrote:
> On 19.11.2012, at 23:48, David Gibson wrote:
>> On Mon, Nov 19, 2012 at 05:26:45PM +0100, Alexander Graf wrote:
>>> On 13.11.2012, at 03:46, David Gibson wrote:
>>>> This patch therefore changes ppcemb_tlb_t to use a fixed 64-bit integer
>>>> which we know is sufficient for all the machines which use this structure.
>>>
>>> hwaddr is always defined to 64bit by now.
>>
>> I know, but there aren't state save helpers for hwaddr, and there are
>> objections to creating them.
(previous discussion on this point:
https://lists.gnu.org/archive/html/qemu-devel/2012-10/msg01456.html )
> Sure, but you can just use the 64bit save helpers now that hwaddr ==
> uint64_t, no?
That would be one approach. I'm a bit sceptical about putting hwaddr
fields in CPU state, though -- it's suggestive that something's
not modelled right. hwaddr is conceptually "big enough for the
biggest bus in the system", and no single component should have
internal state whose size depends on that.
-- PMM
- [Qemu-ppc] [0/12] Pending pseries patches, David Gibson, 2012/11/12
- [Qemu-ppc] [PATCH 02/12] pseries: Use #define for XICS base irq number, David Gibson, 2012/11/12
- [Qemu-ppc] [PATCH 04/12] pseries: Return the token when we register an RTAS call, David Gibson, 2012/11/12
- [Qemu-ppc] [PATCH 01/12] pseries: Fix incorrect initialization of interrupt controller, David Gibson, 2012/11/12
- [Qemu-ppc] [PATCH 06/12] pseries: Add tracepoints to the XICS interrupt controller, David Gibson, 2012/11/12
- [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, David Gibson, 2012/11/12
- Re: [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, Alexander Graf, 2012/11/19
- Re: [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, David Gibson, 2012/11/19
- Re: [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, Alexander Graf, 2012/11/20
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN,
Peter Maydell <=
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, Alexander Graf, 2012/11/20
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, David Gibson, 2012/11/20
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, Alexander Graf, 2012/11/20
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, David Gibson, 2012/11/20
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN, Alexander Graf, 2012/11/21
[Qemu-ppc] [PATCH 07/12] pseries: Split xics irq configuration from state information, David Gibson, 2012/11/12
[Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges, David Gibson, 2012/11/12