Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/2] pseries: set boot-device property only if boot order specified

[David Gibson]

On Wed, Oct 24, 2012 at 07:31:19AM +0530, Avik Sil wrote:
> On 10/24/2012 04:15 AM, David Gibson wrote:
> > On Tue, Oct 23, 2012 at 03:39:35PM +0530, Avik Sil wrote:
> >> Signed-off-by: Avik Sil <address@hidden>
> > 
> > As Anthony suggests, it would be better to explicitly remove the
> > normal default boot order in this patch, after adding it for
> > absolutely everything in the first patch.
> > 
> > This also needs a better patch comment, explaining the significance of
> > the presence/absence of the property on firmware behaviour.
> > 
> Sure. Shall I make the boot order for pseries as NULL string or empty
> string? Current patch handles NULL string.

NULL is better, I think.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson