Re: [Qemu-ppc] [PATCH 00/23] Suppress unused default drives

[Markus Armbruster]

Peter Maydell <address@hidden> writes:

> On 9 August 2012 15:08, Markus Armbruster <address@hidden> wrote:
>> Peter Maydell <address@hidden> writes:
>>> For clarity: what are the negative effects that result from
>>> machines not saying no_floppy &c ?
>>
>> "info block" shows the unused default drives.  For instance,
>>
>>     $ qemu-system-x86_64 -vnc :0 -monitor stdio
>>     QEMU 1.1.50 monitor - type 'help' for more information
>>     (qemu) info block
>>     ide1-cd0: removable=1 locked=0 tray-open=0 io-status=ok [not inserted]
>>     floppy0: removable=1 locked=0 tray-open=0 [not inserted]
>>     sd0: removable=1 locked=0 tray-open=0 [not inserted]
>>     pflash0: removable=0
>> file=/work/armbru/qemu/bld-x86/pc-bios/bios.bin ro=1 drv=raw
>> encrypted=0 bps=0 bps_rd=0 bps_wr=0 iops=0 iops_rd=0 iops_wr=0
>>
>> Drive sd0 is unused here.  Might confuse the uninitiated.  Moreover, you
>> *can* use it for something entirely else, if=sd notwithstanding:
>>
>>     (qemu) device_add lsi
>>     (qemu) device_add scsi-cd,drive=sd0
>
> If/when we get a PCI SD card controller model, would all the PCI
> using machines need to be added to take the 'no default sd card'
> setting out again, or does it get overridden anyway if you say
> "and I'd like an sd controller"?

".no_sdcard = 0" makes sense only when the board uses the default IF_SD
drive.

Existence of an PCI SD card device model for the user to -device is not
relevant for the board's QEMUmachine member no_sdcard.  QEMUmachine
describes the board, not devices that could be added to it.

Only when we add an SD card to a board should its QEMUmachine no_sdcard
go back to 0.