[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 2/5] pseries: Instantiate USB if requested
From: |
Benjamin Herrenschmidt |
Subject: |
Re: [Qemu-ppc] [PATCH 2/5] pseries: Instantiate USB if requested |
Date: |
Tue, 31 Jul 2012 17:35:41 +1000 |
On Tue, 2012-07-31 at 16:09 +1000, David Gibson wrote:
> The pseries machine currently ignores the -usb command line option.
> This patch corrects the problem by having it instantiate a PCI OHCI
> USB host controller when -usb is specified.
>
> Signed-off-by: David Gibson <address@hidden>
Li Zhang <address@hidden> has been owning that patch for a while and
I believe has a better version.
Li, what's the status with it ? Alex ?
Cheers,
Ben.
> ---
> hw/spapr.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/hw/spapr.c b/hw/spapr.c
> index ab5a0c2..740881b 100644
> --- a/hw/spapr.c
> +++ b/hw/spapr.c
> @@ -45,6 +45,7 @@
> #include "kvm.h"
> #include "kvm_ppc.h"
> #include "pci.h"
> +#include "usb.h"
>
> #include "exec-memory.h"
>
> @@ -710,6 +711,12 @@ static void ppc_spapr_init(ram_addr_t ram_size,
> spapr_vscsi_create(spapr->vio_bus);
> }
>
> + /* USB */
> + if (usb_enabled) {
> + pci_create_simple(QLIST_FIRST(&spapr->phbs)->host_state.bus,
> + -1, "pci-ohci");
> + }
> +
> if (rma_size < (MIN_RMA_SLOF << 20)) {
> fprintf(stderr, "qemu: pSeries SLOF firmware requires >= "
> "%ldM guest RMA (Real Mode Area memory)\n", MIN_RMA_SLOF);
- [Qemu-ppc] [0/5] Assorted pseries fixes and updates, David Gibson, 2012/07/31
- [Qemu-ppc] [PATCH 2/5] pseries: Instantiate USB if requested, David Gibson, 2012/07/31
- [Qemu-ppc] [PATCH 3/5] pseries: Add support for -vga option, David Gibson, 2012/07/31
- [Qemu-ppc] [PATCH 4/5] pseries: Remove extraneous prints, David Gibson, 2012/07/31
- [Qemu-ppc] [PATCH 5/5] pseries: Add support for new KVM hash table control call, David Gibson, 2012/07/31
- [Qemu-ppc] [PATCH 1/5] pseries: Update SLOF, David Gibson, 2012/07/31