Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] PPC: e500: add generic e500 platform

[Andreas Färber]

Am 02.07.2012 18:38, schrieb Scott Wood:
> On 07/02/2012 11:33 AM, Stuart Yoder wrote:
>> On Wed, Jun 27, 2012 at 6:51 PM, Scott Wood <address@hidden> wrote:
>>> +static QEMUMachine e500plat_machine = {
>>> +    .name = "e500plat",
>>> +    .desc = "e500plat",
>>> +    .init = e500plat_init,
>>> +    .max_cpus = 15,
>>> +};
>>
>> Can we call the generic e500 machine  "ppce500"?
> 
> I wanted to distinguish the platform from the common e500 code.

The machine name does not need to match the file name, so you can name
it "e500" and place it in e500plat.c or whatever. Common e500 code won't
show up as a user-visible machine I guess.

I concur that "-M e500plat" feels a bit odd for a user option. And
repeating that name in the description is not particularly helpful. ;)

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg