[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] ppce500_spin: Replace assert by hw_error (fixes c
Re: [Qemu-ppc] [PATCH] ppce500_spin: Replace assert by hw_error (fixes compiler warning)
Mon, 30 Apr 2012 16:55:05 +0200
Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120412 Thunderbird/11.0.1
Am 30.04.2012 10:54, schrieb Alexander Graf:
On 28.04.2012, at 17:52, Stefan Weil wrote:
The default case in function spin_read should never be reached,
therefore the old code used assert(0) to abort QEMU. This does not
work when QEMU is compiled with macro NDEBUG defined. In this case
(and also when the compiler does not know that assert never returns),
there is a compiler warning because of the missing return value.
Using hw_error allows an improved error message and aborts always.
Signed-off-by: Stefan Weil <address@hidden>
Thanks, applied to ppc-next. The patch didn't show up on patchworks
btw, not sure what went wrong there. Alex
Did you filter on state "new"? I update the state for my patches.
Are you planning to send a pull request for QEMU 1.1?
I'd like to have this compiler warning fixed in the new version.