Re: [Qemu-ppc] qemu-ga link failure

[Michael Roth]

On Sat, Apr 14, 2012 at 02:48:14AM +0200, Andreas Färber wrote:
> Hello,
> 
> While testing my latest ppc series on ppc, I noticed a qemu-ga link
> failure that I can't reproduce on my x64 box (identical commit):
> 
> [...]
>   LINK  ppc64-softmmu/qemu-system-ppc64
>   CC    qemu-ga.o
>   CC    qga/commands.o
>   CC    qga/guest-agent-command-state.o
>   CC    qga/commands-posix.o
>   CC    qga/channel-posix.o
>   CC    qemu-tool.o
>   GEN   /space/afaerber/qemu-cpu/qapi-generated/qga-qapi-types.c
>   CC    /space/afaerber/qemu-cpu/qapi-generated/qga-qapi-types.o
>   GEN   /space/afaerber/qemu-cpu/qapi-generated/qga-qapi-visit.c
>   CC    /space/afaerber/qemu-cpu/qapi-generated/qga-qapi-visit.o
>   GEN   /space/afaerber/qemu-cpu/qapi-generated/qga-qmp-marshal.c
>   CC    /space/afaerber/qemu-cpu/qapi-generated/qga-qmp-marshal.o
>   LINK  qemu-ga
> /space/afaerber/qemu-cpu/qapi-generated/qga-qmp-marshal.o: In function
> `qmp_marshal_input_guest_fsfreeze_thaw':
> /space/afaerber/qemu-cpu/qapi-generated/qga-qmp-marshal.c:571: undefined
> reference to `qmp_guest_fsfreeze_thaw'
> /space/afaerber/qemu-cpu/qapi-generated/qga-qmp-marshal.o: In function
> `qmp_marshal_input_guest_fsfreeze_freeze':
> /space/afaerber/qemu-cpu/qapi-generated/qga-qmp-marshal.c:537: undefined
> reference to `qmp_guest_fsfreeze_freeze'
> /space/afaerber/qemu-cpu/qapi-generated/qga-qmp-marshal.o: In function
> `qmp_marshal_input_guest_fsfreeze_status':
> /space/afaerber/qemu-cpu/qapi-generated/qga-qmp-marshal.c:503: undefined
> reference to `qmp_guest_fsfreeze_status'
> collect2: ld returned 1 exit status
> make: *** [qemu-ga] Fehler 1
> 
> As can be seen, the softmmus link just fine but qemu-ga fails with
> undefined references. It's a clean checkout (of a branch that only
> touches target-ppc) and an in-tree build configured with
> --target-list=ppc-softmmu,ppc64-softmmu, reproducible with -j2 and
> without. Builds fine with --disable-guest-agent.
> 
> Anyone any idea?

Looks like a regression I introduced when fixing a recent build issue with
*BSD. Please give the incoming patch a shot.

> 
> Regards,
> Andreas
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
>